This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
New modes #34
Merged
New modes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jennytoo
commented
Dec 16, 2019
jennytoo
commented
- New Fireflies mode. Similar in concept to Sparkle, but eases the LEDs in and out and runs several at a time on different timers with random timing.
- New Saturation Fade mode. Similar idea to Color Wipe or Rainbow, fills the strip up with a solid color, applying a sine wave to the saturation channel resulting in a pleasing gradient between the given color and white. Shifts the alignment along the strip over the span of 1..10 seconds, configurable.
Since introducing the dynamic modes the initial mode was not taken from the configuration. Instead the "Colour" mode was always used
* Added fireflies mode * Add speed options for confetti, sparkle mode to the webpage (but commented out as the speed limiter needs to be modified)
Fades between white and a fully saturation color.
|
Cool effects. Both work for me :) |
Glad to hear that. I was a little worried I made errors during the cherry pick as I had to extract it from my main branch. :) |
In previous versions the board kept runtime information per mode when switching between modes. This could have odd effects, for example the "color wipe" mode could be invisible for some time when it was in the "fade out" phase when switching to the mode. This change now separates the mode member variables into two categories: Config: These are initialized with their default values at class level once and need to be overridden with the applyConfig() method. State: These are not allowed to be persisted with the config and may change at any time during animation. They need to be initialized in the initialize() method.
|
Looks great. I'll have a play with them when I'm home after the Christmas period and merge them in. |
The device name was always "RGB WiFi Lamp" for my devices. Because the name is available to the frontend with the settings websocket message, this commit adds a small JS function that updates the page title and logo area with the device name.
Different fixes
Always start modes with initial settings
* Added fireflies mode * Add speed options for confetti, sparkle mode to the webpage (but commented out as the speed limiter needs to be modified)
Fades between white and a fully saturation color.
|
Ended up re basing the pull with the master and added 2 lines. Nice and easy. Modes work great, awesome stuff! |
|
Cleaned up some stuff as well. Merging it in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.