don't provide custom class names #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying to figure out a test case. The previous code seems to be fundamentally wrong and I'm not yet sure how we ever got into the previous block. My hunch is that if I do some type erasion we may hit this. Will test the theory in the morning |
tristanlabelle
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WinUI runtime queries objects for class names when applying templates and styles. If you provide a class name that isn't recognized then it will fail to apply those properties. generally, custom types are all handled through code generated by the xaml compiler for you, but we don't have all of that machinery.
this regressed as part of #108. i really knew better considering the comment that i happily ignored (which i restored in this PR). past steve would be disappointed with me :D