Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make static functions throw just like instance functions #146

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Make static functions throw just like instance functions #146

merged 1 commit into from
Mar 13, 2024

Conversation

tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Mar 13, 2024 •
edited
Loading

Currently instance functions throw but static functions do not. There is no reason for this difference, so align on making all functions throw to make their errors possible to handle.

Fixes #145

@tristanlabelle tristanlabelle requested a review from a team as a code owner March 13, 2024 16:58
darinf
darinf approved these changes Mar 13, 2024
View reviewed changes
Copy link

@darinf darinf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks straightforward, thanks!

@tristanlabelle tristanlabelle merged commit acd4048 into main Mar 13, 2024
1 check passed
@tristanlabelle tristanlabelle deleted the tristan/throwing-static-funcs branch March 13, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinf darinf darinf approved these changes

@sherryshao sherryshao sherryshao approved these changes

@stevenbrix stevenbrix Awaiting requested review from stevenbrix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static functions should be throwing like instance functions
3 participants
@tristanlabelle @darinf @sherryshao