Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove script to publish dist dir #691

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

thebuilder
Copy link
Owner

@thebuilder thebuilder commented Jul 10, 2024

Before, when publishing, all required files were copied into the dist directory, and it was published as the root.

Due to ESM exports, it's now possible to cleanly expose the test-utils without exposing "dist" in the imports.

When publishing, all required files were copied into the `dist` dir, and it was published as the "root".

Because of ESM exports, it's now possible to cleanly expose the `test-utils` with exposing "dist" in the imports.
Copy link

stackblitz bot commented Jul 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-intersection-observer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 8:48pm

Copy link

pkg-pr-new bot commented Jul 10, 2024

commit: 214cf98

react-intersection-observer

npm i https://pkg.pr.new/thebuilder/react-intersection-observer@691

@thebuilder thebuilder merged commit 6e90b03 into main Jul 11, 2024
17 checks passed
@thebuilder thebuilder deleted the feat/remove-dist-copy branch July 11, 2024 07:06
@thebuilder
Copy link
Owner Author

🎉 This issue has been resolved in version 9.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant