Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix package exports and simplify build #695

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

RobinTail
Copy link
Contributor

Fixes #694 , @thebuilder

Screenshot 2024-07-11 at 11 23 26

Copy link

stackblitz bot commented Jul 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Jul 11, 2024

@RobinTail is attempting to deploy a commit to the Daniel Schmidt's projects Team on Vercel.

A member of the Team first needs to authorize it.

@RobinTail RobinTail changed the title Fix exports Fix exports and simplify build Jul 11, 2024
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link

pkg-pr-new bot commented Jul 11, 2024

commit: f30e724

react-intersection-observer

npm i https://pkg.pr.new/thebuilder/react-intersection-observer@695

@thebuilder thebuilder changed the title Fix exports and simplify build fix: package exports and simplify build Jul 11, 2024
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-intersection-observer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 10:00am

@RobinTail
Copy link
Contributor Author

What's failing in Vercel, @thebuilder ? Can't see it

@thebuilder
Copy link
Owner

What's failing in Vercel, @thebuilder ? Can't see it

I made a PR on your fork - It's the the storybook:build task that tries to run the build:bundle task that was removed.

@RobinTail
Copy link
Contributor Author

Needs your authorization to run Vercel check again

@RobinTail
Copy link
Contributor Author

It seems to be working!
Wheeee! :)

@thebuilder thebuilder changed the title fix: package exports and simplify build feat: fix package exports and simplify build Jul 11, 2024
@thebuilder
Copy link
Owner

Looks good! 🎉

@thebuilder thebuilder merged commit c9cef8f into thebuilder:main Jul 11, 2024
10 checks passed
@RobinTail
Copy link
Contributor Author

Thank you for all the support and wonderful collaboration, @thebuilder ! ❤️

@thebuilder
Copy link
Owner

🎉 This issue has been resolved in version 9.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thebuilder
Copy link
Owner

Thank you for all the support and wonderful collaboration, @thebuilder ! ❤️

And thank you for going in and fixing up the build flow. It's been bugging me for a long time. Much cleaner now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken exports
2 participants