Update storage-providers.md #298
Conversation
Improve verbosity of Isilon provider parameters based on customer questions.
|
|
Current coverage is 25.03% (diff: 100%)@@ master #298 diff @@
==========================================
Files 46 46
Lines 2708 2708
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 678 678
Misses 1960 1960
Partials 70 70
|
| @@ -45,8 +45,8 @@ The following items are configurable specific to this driver. | |||
|
|
|||
| * `volumePath` represents the location under `/ifs/volumes` to allow volumes to | |||
| be created and removed. | |||
| * `nfsHost` is the configurable host used when mounting exports | |||
| * `dataSubnet` is the subnet the REX-Ray driver is running on | |||
| * `nfsHost` is the configurable NFS server hostname or IP (often a SmartConnect name) used when mounting exports | |||
There was a problem hiding this comment.
Hi @spiegela,
Please update this commit to limit column widths to 80 characters.
| * `nfsHost` is the configurable host used when mounting exports | ||
| * `dataSubnet` is the subnet the REX-Ray driver is running on | ||
| * `nfsHost` is the configurable NFS server hostname or IP (often a SmartConnect name) used when mounting exports | ||
| * `dataSubnet` is the subnet the REX-Ray driver is running on. This is used for the NFS export host ACLs. |
There was a problem hiding this comment.
Hi @spiegela,
I also learned in school to use two spaces after a period, but that rule has since been changed thanks to the interwebs. The convention is now a single space after a period. Please update. Thank you. Also, please limit the column width to 80 characters. Thanks again.
This patch updates the previous commit with some suggested fixes from the associated PR at #298.
|
Hi @spiegela, I went ahead and merged this PR into |
|
Cool. Thanks, @akutz. It's going to take me some time to get used to single-spacing a new sentence... |
Improve verbosity of Isilon provider parameters based on customer questions.