Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment mentioning that FilesystemCache can be used when APCu isn't available #662

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

shish
Copy link
Contributor

@shish shish commented Mar 14, 2024

Add a comment mentioning that FilesystemCache can be used when APCu isn't available

APCu isn't enabled by default, which makes the example crash, and there are no hints as to what the user is supposed to do about it

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (53f9d49) to head (87d2e68).
Report is 69 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #662      +/-   ##
============================================
- Coverage     95.72%   95.29%   -0.44%     
- Complexity     1773     1818      +45     
============================================
  Files           154      171      +17     
  Lines          4586     4841     +255     
============================================
+ Hits           4390     4613     +223     
- Misses          196      228      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oojacoboo
Copy link
Collaborator

I think this one could be updated to be a code comment. But APCu should be encouraged for performance purposes. People shouldn't assume that the filesystem is suitable for cache. It really shouldn't be used.

So, it should stay as APCu with a comment that the Filesystem can be used for testing, but isn't encouraged for performance reasons!

…sn't available

APCu isn't enabled by default, which makes the example crash, and there are no hints as to what the user is supposed to do about it
@shish shish changed the title Use Filesystem as example cache Add a comment mentioning that FilesystemCache can be used when APCu isn't available Mar 20, 2024
@oojacoboo oojacoboo merged commit 8ae940e into thecodingmachine:master Mar 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants