Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically regenerate the files #264

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch from 915c5fd to 6b2bcf7 Compare January 19, 2021 04:00
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 4 times, most recently from 79eca2e to 9f54316 Compare January 26, 2021 03:21
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 2 times, most recently from f32e96d to f442b8f Compare January 30, 2021 03:22
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 3 times, most recently from 52975b6 to 43aee4d Compare February 14, 2021 03:14
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch from 43aee4d to 975474d Compare February 22, 2021 03:15
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 2 times, most recently from e2cf66c to 3c42bc2 Compare March 18, 2021 03:15
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch from 3c42bc2 to 5da53ec Compare March 24, 2021 03:18
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch from 5da53ec to 0081656 Compare March 31, 2021 03:23
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 4 times, most recently from c1076ca to 2e90cb3 Compare April 20, 2021 03:24
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 5 times, most recently from 56f7746 to 96481be Compare April 30, 2021 03:07
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch from 96481be to 8d07b3d Compare May 5, 2021 03:05
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 3 times, most recently from ea4fc80 to 6cb8a1c Compare June 5, 2021 03:33
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 5 times, most recently from 5573a25 to f5c31c9 Compare June 14, 2021 03:05
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 3 times, most recently from 0bcbb20 to 0bda707 Compare June 24, 2021 03:04
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 3 times, most recently from 274b37f to 96362e3 Compare June 27, 2021 03:04
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 4 times, most recently from c79b822 to 2c2bb00 Compare July 8, 2021 03:04
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 2 times, most recently from 2500c40 to b4874a9 Compare July 17, 2021 03:04
@dbrekelmans dbrekelmans mentioned this pull request Jul 19, 2021
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch 2 times, most recently from 327a1df to 082abf8 Compare July 24, 2021 03:03
@github-actions github-actions bot force-pushed the create-pull-request/regenerate-files branch from 082abf8 to 6ad756d Compare July 27, 2021 03:04
generated/apache.php Show resolved Hide resolved
generated/bzip2.php Show resolved Hide resolved
generated/dom.php Show resolved Hide resolved
* as a native DOMElement node.
*
* @param \SimpleXMLElement $node The SimpleXMLElement node.
* @return \DOMElement|false The DOMElement node added.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The |false doesn't match the actual return type

generated/exec.php Show resolved Hide resolved
$result = \finfo_open($flags, $magic_database);
}else {
$result = \finfo_open($flags);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if-else is not necessary.

Passing null or an empty string will be equivalent to the default value.

https://www.php.net/manual/en/function.finfo-open

'solr_get_version',
'sort',
'spl_autoload_register',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is deleted. The function still exists in PHP8.

https://www.php.net/manual/en/function.spl-autoload-register.php

generated/image.php Show resolved Hide resolved
generated/image.php Show resolved Hide resolved
* @throws SplException
*
*/
function spl_autoload_register(callable $autoload_function = null, bool $throw = true, bool $prepend = false): void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this has been deleted.. it's still a function on PHP 8

@dbrekelmans dbrekelmans merged commit df77f2d into master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants