Manually implement stream_context_set_options in a php8.1-compatible way #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Dec 3, 2024
Comment on lines
+18
to
+21
| // returns literal "true", which php8.1 doesn't support, so we implement | ||
| // this one manually and return "bool" | ||
| 'stream_context_set_options', | ||
| // This function need to return false when iterating on an end of file. |
There was a problem hiding this comment.
maybe we can rewrite a :true or :false return type in the generator to bool instead of this hardcoded 1 function fix? other functions might have the same problem?
There was a problem hiding this comment.
Seems sensible, #497 does it that way instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.