Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slugify not replacing to empty string #4900

Closed
wants to merge 1 commit into from
Closed

Fix slugify not replacing to empty string #4900

wants to merge 1 commit into from

Conversation

taiwanleaftea
Copy link
Contributor

fix for Slugify for Voyager - Russian map #3027

fix for Slugify for Voyager - Russian map #3027
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #4900 into 1.4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #4900   +/-   ##
=========================================
  Coverage     62.93%   62.93%           
  Complexity     1373     1373           
=========================================
  Files           194      194           
  Lines          3996     3996           
=========================================
  Hits           2515     2515           
  Misses         1481     1481           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e6775...a2b65e5. Read the comment docs.

@MrCrayon
Copy link
Collaborator

Thanks for the submission, since you are first time contributor a couple of advices:

  • Use a descriptive title like: Fix slugify not replacing to empty string, so who is going to compile the release notes can use that.
  • Add labels, in this case bugfix
  • When PR fixes a bug put in description: Fixes Slugify for Voyager - Russian map  #3027 (or Closes for features) that will automatically close related issue when merged.

You can edit both title and description, also if you need to change your PR you can just push new commits to your branch.

@taiwanleaftea taiwanleaftea changed the title Fix for #3027 Fix slugify not replacing to empty string Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants