Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slugify.js not replacing to empty string #4901

Merged
merged 2 commits into from
May 17, 2020

Conversation

taiwanleaftea
Copy link
Contributor

fixes #3027

@taiwanleaftea
Copy link
Contributor Author

There is a bugfix, but I can't add the label to the pull request.

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #4901 into 1.4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.4    #4901   +/-   ##
=========================================
  Coverage     62.96%   62.96%           
  Complexity     1372     1372           
=========================================
  Files           194      194           
  Lines          4007     4007           
=========================================
  Hits           2523     2523           
  Misses         1484     1484           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b3eb20...e66408d. Read the comment docs.

@emptynick
Copy link
Collaborator

Don't worry, you can't add labels.

Copy link
Collaborator

@MrCrayon MrCrayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@emptynick emptynick merged commit 09e6802 into thedevdojo:1.4 May 17, 2020
rozaverta added a commit to rozaverta/voyager that referenced this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slugify for Voyager - Russian map
3 participants