Check user permissions before uploading file #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoyagerController@upload to upload images. This PR introduces checks to verify that user has permission to edit or add the BREAD and that there is a visibile tinyMCE editor in that BREAD action.
Codecov Report
@@ Coverage Diff @@
## 1.4 #5072 +/- ##
============================================
- Coverage 63.31% 63.21% -0.10%
- Complexity 1379 1383 +4
============================================
Files 194 194
Lines 4075 4081 +6
============================================
Hits 2580 2580
- Misses 1495 1501 +6
Continue to review full report at Codecov.
|
fletch3555
reviewed
Sep 23, 2020
emptynick
approved these changes
Nov 28, 2020
MrCrayon
deleted the
feature-add-permission-checks-in-tinymce-image-upload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VoyagerController@upload is used by tinyMCE to upload images.
This PR introduces checks to verify that user has permission to edit or add the BREAD and that there is a visibile tinyMCE editor in that BREAD action.