Fix hasOne and hasMany setting in BREAD #5194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Store the" was picking the wrong table for hasOne and hasMany.
It should be the same table so it can be populateed server side.
Removed the check for `display:block` because everything is done with javascript at startup with `trigger('change')`
Codecov Report
@@ Coverage Diff @@
## 1.4 #5194 +/- ##
=========================================
Coverage 63.37% 63.37%
Complexity 1394 1394
=========================================
Files 195 195
Lines 4120 4120
=========================================
Hits 2611 2611
Misses 1509 1509 Continue to review full report at Codecov.
|
emptynick
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the was picking the wrong table for
hasOneandhasMany.It should be the same table so it can be populated server side.
Removed the check for
display:blockbecause everything is done with javascript at startup withtrigger('change')Fixes #5074