Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action buttons on per-row base #5355

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Action buttons on per-row base #5355

merged 4 commits into from
Aug 31, 2021

Conversation

emptynick
Copy link
Collaborator

This PR makes it possible to show/hide action buttons on a per-row base by implementing a method called shouldActionDisplayOnRow($row):

<?php

public function shouldActionDisplayOnRow($row)
{
    return $row->someField >= 10;
}

@emptynick emptynick changed the base branch from 1.4 to 1.5 August 31, 2021 08:33
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #5355 (9db5663) into 1.5 (39be175) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.5    #5355      +/-   ##
============================================
+ Coverage     63.51%   63.53%   +0.01%     
- Complexity     1399     1400       +1     
============================================
  Files           195      195              
  Lines          4133     4135       +2     
============================================
+ Hits           2625     2627       +2     
  Misses         1508     1508              
Impacted Files Coverage Δ
src/Actions/AbstractAction.php 85.00% <100.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39be175...9db5663. Read the comment docs.

@emptynick emptynick merged commit 5a4a4af into 1.5 Aug 31, 2021
@emptynick emptynick deleted the 1.4-actions-per-row branch August 31, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants