Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct abbreviation for minutes in settings #11

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

DigiH
Copy link
Member

@DigiH DigiH commented Jun 24, 2022

Correct abbreviation for minutes in settings

I know this is a fine detail, and I'm sure no user would think the Update Interval setting shows a certain amount of metres, but being an application which in the widgets shows mainly scientific data for sensors I think it would be good form to also have the correct units displaying in other parts of the app.

Before
minutesOLD

After
minutesNEW

Fine on macOS even with the maximum interval setting of 360 min, but needs checking on all other platforms, if it might not require a wider selection box, or possibly even just the number in it and a changed text label like "Update interval in min/minutes"

https://github.com/theengs/app/actions/runs/2556733375

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@1technophile
Copy link
Member

Thanks

@1technophile
Copy link
Member

@emericg do we need to check this kind of modifications on all platforms or will the component resize adequately?

@1technophile 1technophile merged commit 1b3fcce into development Jun 28, 2022
@1technophile 1technophile deleted the minutes-abbreviation branch June 28, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants