Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typo fixes and proposal for ellipsis #31

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

DigiH
Copy link
Member

@DigiH DigiH commented Oct 29, 2022

Small typo fixes and proposal for using dedicated ellipsis character

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

Small typo fixes and proposal for using dedicated ellipsis character
@emericg
Copy link
Collaborator

emericg commented Oct 29, 2022

Grammar looks good (probably ^^)
Regarding the ellipsis, while I really don't care, what I can tell you is the next person that will do anything in the app or in the documentation won't be instinctively using them...
Like the 3/4 space spaces or the single character for ℃, these things are invisible to anyone not looking for them.

@DigiH
Copy link
Member Author

DigiH commented Oct 29, 2022

Possibly with the ellipsis, but since all the OSs which the app runs on, Windows, macOS, iOS and Android, use this ellipsis character instead of three periods, I just thought it would be nicely consistent with the OS displays.

Like the 3/4 space spaces or the single character for ℃, these things are invisible to anyone not looking for them.

For people like me they just jump out, probably also because that's what also did to make a living ;)

@1technophile
Copy link
Member

Thanks for the PR

@1technophile 1technophile merged commit 6ead3a3 into theengs:development Oct 29, 2022
@DigiH DigiH deleted the typo-fixes branch October 30, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants