Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device IDs adjustment #59

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Device IDs adjustment #59

merged 1 commit into from
Feb 7, 2023

Conversation

DigiH
Copy link
Member

@DigiH DigiH commented Dec 23, 2022

Adjusting device IDs for CGG1, CGDK2, CGP1W and CGD1 to correctly only use the second byte.

As described in #56

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

Adjusting device IDs for CGG1, CGDK2, CGP1W and CGD1 to correctly only use the second byte.
@emericg
Copy link
Collaborator

emericg commented Dec 24, 2022

If you are confident the first byte should be ignored, I'm ok with it.
Is there any other values than 0x08 and 0x88 that have been seen in the wild?

@DigiH
Copy link
Member Author

DigiH commented Dec 24, 2022

AFAIK it can also be 0x04 for some Qingping devices, and whichever additional variations come up in the future or already exist. I'm not sure if this is hardware revisions or region variations, but with the second byte already getting additional variants I think this is enough of a catch up already, unless you want to keep doing that with the first byte as well.

Just doing a quick search here I also found

https://github.com/Bluetooth-Devices/qingping-ble/blob/main/src/qingping_ble/parser.py

which makes me realise we should probably also extend the existing device IDs with these additional variations, affecting CGG1 and CGDN1 for Decoder, with the recent addition of

https://github.com/Bluetooth-Devices/qingping-ble/pull/18/files

@emericg
Copy link
Collaborator

emericg commented Feb 7, 2023

Indeed, it looks like 0x04 and 0x80 can occur as well, and I (probably) remember a 0x48, but maybe not from the type of sensor we are interested in.

@emericg emericg merged commit c04aa09 into theengs:development Feb 7, 2023
@DigiH DigiH deleted the device-ids branch February 7, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants