Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ruff and mypy in pre-commit #125

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Run ruff and mypy in pre-commit #125

merged 1 commit into from
Apr 12, 2023

Conversation

koenvervloesem
Copy link
Member

Description:

Add some code quality checks in pre-commit:

  • Run ruff instead of flake8 and isort. This runs much faster.
  • Run mypy and fix some typing issues.

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@koenvervloesem koenvervloesem merged commit 35d46af into development Apr 12, 2023
@koenvervloesem koenvervloesem deleted the ruff branch April 12, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant