Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/websockets-ssl #160

Merged

Conversation

radim-kliment
Copy link
Contributor

Description:

Added support for websocket transport layer and activation of ssl.

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@radim-kliment radim-kliment changed the title feat/websockets ssl feat/websockets-ssl Aug 9, 2023
@koenvervloesem
Copy link
Member

Thanks for these useful features!

Can you:

  • Run pre-commit and fix the found issues.
  • Rename all parameters that have ssl in their name to use tls because everyone should use TLS these days.

@radim-kliment
Copy link
Contributor Author

I fix errors from lint, but I get this error, which is line of code I did not edit:

TheengsGateway/diagnose.py:108: error: Module has no attribute "freedesktop_os_release" [attr-defined]

@koenvervloesem
Copy link
Member

You're probably running this on a Python version lower than 3.10? Don't worry about it then.

@koenvervloesem koenvervloesem merged commit 5660e6a into theengs:development Aug 9, 2023
1 check passed
@radim-kliment
Copy link
Contributor Author

yep, Iam running this on python 3.9

@koenvervloesem
Copy link
Member

The diagnose module should run fine because the code checks whether the Python version >= 3.10 before calling freedesktop_os_release(), but apparently the linter doesn't know this.

Anyway, thanks again for your contribution! This is a nice addition for the upcoming release.

@1technophile
Copy link
Member

Hello,
Thanks!
Maybe the options should be added into the docs?
https://github.com/theengs/gateway/blob/development/docs/use/use.md

@koenvervloesem
Copy link
Member

I documented the options in #161 and changed the types to int for consistency with the other options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants