Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo preventing startup #169

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

kw217
Copy link
Contributor

@kw217 kw217 commented Sep 18, 2023

Description:

Fixes a typo in ble_gateway causing a fatal error on startup.

Checklist:

  • [ x] The pull request is done against the latest development branch
  • [ x] Only one feature/fix was added per PR and the code change compiles without warnings
  • [ x] I accept the DCO.

@koenvervloesem
Copy link
Member

This shouldn't fail, but there have been some changes in Python's typing in recent versions, so this is probably version-related. Can you:

  • show the exact output on startup, including the fatal error and complete stack trace?
  • show the output of python -m TheengsGateway.diagnose?

@koenvervloesem koenvervloesem merged commit 6fc9383 into theengs:development Sep 22, 2023
1 check passed
@koenvervloesem
Copy link
Member

I investigated this, the current code fails on Python 3.8. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants