Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option -in/--insecure_tls to not check certificate hostname #241

Closed

Conversation

mcesar-rlacruz
Copy link
Contributor

@mcesar-rlacruz mcesar-rlacruz commented Feb 28, 2024

Description:

New command line option -ti/--tls_insecure is added. When enabled, causes the TLS engine not to check the server hostname against the hostname contained in the certificate provided by the server. This may be needed in scenarios where we are accessing an MQTT server having a valid, CA signed, certificate from an internal network, where such server is accessed via a local name or even a local IP address (192.168.x.y, or even 127.0.0.1).

This option is ignored if TLS is not enabled.

Checklist:

  • [*] I have created the pull request against the latest development branch
  • [*] I have added only one feature/fix per PR and the code change compiles without warnings
  • [*] I accept the Developer Certificate of Origin (DCO).

@mcesar-rlacruz mcesar-rlacruz marked this pull request as ready for review February 28, 2024 18:00
@koenvervloesem
Copy link
Member

Thanks for this contribution! Can you run pre-commit like explained here to solve code issues: https://gateway.theengs.io/participate/development.html

@koenvervloesem
Copy link
Member

Thanks! This just needs a run of ruff format on TheengsGateway/ble_gateway.py and an addition of the new option to the documentation (https://github.com/theengs/gateway/blob/development/docs/use/use.md#for-a-regular-installation-1), and then this looks ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants