Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mfr key with company name based on company ID #95

Merged
merged 2 commits into from
Feb 11, 2023
Merged

Conversation

koenvervloesem
Copy link
Member

@koenvervloesem koenvervloesem commented Jan 31, 2023

Description:

This adds a mfr key in the JSON output, with a company name based on the company ID in the manufacturer data, using bluetooth-numbers. The logic is:

  • if decoded and (compliant and no beacon) -> add company name
  • if not decoded -> add company name, let the user decide whether to use the information

In other cases we don't add the company name, because this would be confusing.

A device is considered a beacon when its model_id is one of "ABTemp", "IBEACON", "MS-CDP", or "RDL52832".

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@1technophile
Copy link
Member

Thanks

@1technophile 1technophile merged commit 36c074c into development Feb 11, 2023
@1technophile 1technophile deleted the add_mfr branch February 11, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants