Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-8 encoding to read long description in setup.py #98

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

koenvervloesem
Copy link
Member

Description:

This fixes issue #97 by making the encoding explicit when reading the long description of the package in setup.py. When not set explicitly, Windows uses cp1252 encoding and installation of the package fails.

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@1technophile
Copy link
Member

Thanks

@1technophile 1technophile merged commit 0419529 into development Feb 11, 2023
@1technophile 1technophile deleted the use_utf8_encoding branch February 11, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants