Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cidr/netmask optional for IPv6 subnets #878

Closed
evgeni opened this issue Jul 17, 2020 · 0 comments · Fixed by #880
Closed

make cidr/netmask optional for IPv6 subnets #878

evgeni opened this issue Jul 17, 2020 · 0 comments · Fixed by #880

Comments

@evgeni
Copy link
Member

evgeni commented Jul 17, 2020

Previously, the API required the mask parameter and we either passed what the user entered or calculated it from cidr. The API never documented the cidr param so we never sent it. Now it does and so we send both. That's fine.

However, now both mask and cidr are optional, as they are only required for IPv4 subnets, but not for v6 ones. We still have required_one_of=[mask,cidr] -- there is no required_one_of_if=['type=IPv4', [mask,cidr] so we would need to wrap that somehow ourself, or keep mask/cidr required for now, which is what I landed on.

Originally posted by @evgeni in #876 (comment)

mdellweg added a commit to mdellweg/foreman-ansible-modules that referenced this issue Jul 17, 2020
evgeni pushed a commit that referenced this issue Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant