Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role for managing hostgroups #1116

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Dec 22, 2020

Putting into draft initially as I want to work on a few better examples. Ideas welcome on what we can show here.

roles/hostgroups/README.md Outdated Show resolved Hide resolved
roles/hostgroups/README.md Outdated Show resolved Hide resolved
roles/hostgroups/README.md Outdated Show resolved Hide resolved
@evgeni
Copy link
Member

evgeni commented Dec 23, 2020

few comments, but no good ideas about more examples

roles/hostgroups/README.md Outdated Show resolved Hide resolved
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny nit on the test, but nothing major/blocking

tests/test_playbooks/hostgroups_role.yml Outdated Show resolved Hide resolved
tests/test_playbooks/hostgroups_role.yml Outdated Show resolved Hide resolved
@evgeni
Copy link
Member

evgeni commented Apr 7, 2021

aaah, changelog entry please XD

@ehelms
Copy link
Member Author

ehelms commented Apr 7, 2021

Added

@evgeni evgeni merged commit fd77093 into theforeman:develop Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants