redhat_manifest - set default quantity to 1
#1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code decides whether subs need to be attached or not by the presence of the `pool_id` parameter. However, to be able to actually attach a pool, one also needs to pass the quantity. We could document that and set a `required_together` property, or do the sensible thing and just default the `quantity` to 1, which is a sane default in the days of SCA where we need to attach a sub to make Katello aware of the fact that we have access to said content, but otherwise don't need the *correct amount* of subs attached for providing them to clients.
|
I second the default of one. I was thinking to ask you this, but you already did it. |
|
+1 from me as well, especially given that #1494 will make the default manifest mode |
ehelms
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code decides whether subs need to be attached or not by the presence of the
pool_idparameter. However, to be able to actually attach a pool, one also needs to pass the quantity.We could document that and set a
required_togetherproperty, or do the sensible thing and just default thequantityto 1, which is a sane default in the days of SCA where we need to attach a sub to make Katello aware of the fact that we have access to said content, but otherwise don't need the correct amount of subs attached for providing them to clients.