drop fallback to Host API when Reports API fails #1808
Merged
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The results the Host API returns are different from the Reports API, so when the user asks for Reports API (via `use_reports_api`), they should get exactly that, as otherwise their Playbooks/Roles might miss-behave given different data is fed into them.
mdellweg
approved these changes
Dec 5, 2024
evgeni
commented
Dec 5, 2024
| @@ -0,0 +1,2 @@ | |||
| bugfixes: | |||
There was a problem hiding this comment.
I wasn't sure about this. Conceptually it's a bugfix (you really do not want wrong data when running stuff), but it's also technically a breaking change 🙈
Realistically, this is only a breaking change for users who
- do not have
foreman_ansibleinstalled - have
use_reports_api: true - have ignored the "Failed to use Reports API, falling back to Hosts API" warning ever since
🤷♀️
There was a problem hiding this comment.
And additionally if that thing ever triggered, there inventory ran into the wrong data (format) and presumably failed anyway down the line? IMHO It definitely is a bugfix. It breaks bug to bug compatibility, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The results the Host API returns are different from the Reports API, so
when the user asks for Reports API (via
use_reports_api), they shouldget exactly that, as otherwise their Playbooks/Roles might miss-behave
given different data is fed into them.