Rework procedure to enable BMC on Smart Proxies #2825
Conversation
|
I have tested both procedures on Foreman Server and Smart Proxy Server 3.9. Does this make sense to you? Can you confirm that |
pr-processor
bot
added
Waiting on contributor
maximiliankolb
force-pushed
the
extend_bmc
branch
from
bec98ad
to
553c05b
Compare
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
Yes, this has to be installed on Foreman or Smart Proxy respectively. |
maximiliankolb
force-pushed
the
extend_bmc
branch
from
553c05b
to
f5e36f5
Compare
pr-processor
bot
added
Waiting on contributor
There was a problem hiding this comment.
Looking good!
I'm for including installation of the package in the procedure.
Thanks for fixing the bare-metal stuff :)
I'm not sure if all the procedures are limited to bare metal, but let's keep it like this for now and I'll revisit it later during the Provisioning revamp.
maximiliankolb
force-pushed
the
extend_bmc
branch
from
f5e36f5
to
02efa9b
Compare
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
* Clarifiy enabling BMC Smart Proxy per subnet * Simplify enabling BMC on Smart Proxies * Sort options in alphabetical order
Do not cherry-pick; only affected nightly. See 053ba7c75621b85934a649765249b936b5dc8489 in foreman-packaging & "packages/foreman/rubygem-rubyipmi/rubygem-rubyipmi.spec"
maximiliankolb
force-pushed
the
extend_bmc
branch
from
02efa9b
to
c245b6a
Compare
There was a problem hiding this comment.
Now, there is no more mention at all if and where ipmitool needs to be installed.
There was a problem hiding this comment.
The way I understand this: foreman-installer installs a package that has a dependency to "ipmitools"; so we don't have to document it/install it manually. See #2825 (comment)
Is this correct for Foreman nightly? @ekohl
There was a problem hiding this comment.
@maximiliankolb it should be fixed for RPMs in nightly. For 3.8, 3.9 and 3.10 it'll need to wait for the next release. I also noticed it's a problem for Debian, so it may not be a bad thing to keep it in for now.
There was a problem hiding this comment.
Thank you; confirmed locally:
# run AlmaLinux 8.9
# add Foreman nightly repo
# dnf install rubygem-rubyipmi
Installing:
rubygem-rubyipmi noarch 0.11.1-2.el8 foreman 35 k
Installing dependencies:
ipmitool x86_64 1.8.18-19.el8 appstream 394 k
ruby
Before, I was searching for "ipmitool" on yum.theforeman.org and couldn't find it. Well d'oh! So yes, we do not need to mention it in the docs for nightly.
So we should rebase on merge and then only cherry-pick the first two commits to "3.10" and "3.9".
Clarifiy enabling BMC Smart Proxy per subnet
Simplify enabling BMC on Smart Proxies
Sort options in alphabetical order
I am familiar with the contributing guidelines.
Please cherry-pick my commits into: