Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EL9 links to the nightly upgrade guide #3046

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

ianballou
Copy link
Contributor

There may be more spots that need EL9.

Copy link

github-actions bot commented May 23, 2024

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Jun 4, 2024
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the whole procedures more separate. For example, dnf -y module switch-to postgresql:13 doesn't work on EL9 because it ships PG 13 in the base. We also don't have the foreman:el8 module on EL9.

@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Jun 6, 2024
@ianballou
Copy link
Contributor Author

It felt a bit verbose to copy / paste the upgrade bits and repeat them for EL8 and EL9, so I added some "if" conditionals for EL 8 users. If anyone has a suggestion for a neat way to separate them even more, let me know via a change request.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In itself this is correct and improves it.

Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks.

@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Jun 24, 2024
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Jun 24, 2024
@ianballou
Copy link
Contributor Author

@Lennonka I fixed the issues you found.

Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more structural suggestion.

Comment on lines 86 to 98
. On {EL} 9: Update repositories:
+
[options="nowrap" subs="attributes"]
----
ifdef::katello[]
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm \
https://yum.theforeman.org/katello/{KatelloVersion}/katello/el9/x86_64/katello-repos-latest.rpm
endif::[]
ifdef::foreman-el[]
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm
endif::[]
----
. On {EL} 8: Update repositories:
Copy link
Contributor

@Lennonka Lennonka Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. On {EL} 9: Update repositories:
+
[options="nowrap" subs="attributes"]
----
ifdef::katello[]
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm \
https://yum.theforeman.org/katello/{KatelloVersion}/katello/el9/x86_64/katello-repos-latest.rpm
endif::[]
ifdef::foreman-el[]
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm
endif::[]
----
. On {EL} 8: Update repositories:
. Update repositories:
* On {EL} 9:
+
[options="nowrap" subs="attributes"]
----
ifdef::katello[]
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm \
https://yum.theforeman.org/katello/{KatelloVersion}/katello/el9/x86_64/katello-repos-latest.rpm
endif::[]
ifdef::foreman-el[]
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm
endif::[]
----
* On {EL} 8:

This structure would be a bit less prone to oversights.

Comment on lines 45 to 57
. On {EL} 9: Update repositories:
+
[options="nowrap" subs="attributes"]
----
ifdef::katello[]
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm \
https://yum.theforeman.org/katello/{KatelloVersion}/katello/el9/x86_64/katello-repos-latest.rpm
endif::[]
ifdef::foreman-el[]
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm
endif::[]
----
. On {EL} 8: Update repositories:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here.

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Needs re-review labels Jun 24, 2024
@apinnick
Copy link
Contributor

apinnick commented Aug 8, 2024

@ianballou Can you please take a look at this?

@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Aug 9, 2024
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supergreen!

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ian, LGTM.

@maximiliankolb maximiliankolb merged commit d68a4c5 into theforeman:master Aug 23, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants