-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EL9 links to the nightly upgrade guide #3046
Add EL9 links to the nightly upgrade guide #3046
Conversation
The PR preview for 6ba9955 is available at theforeman-foreman-documentation-preview-pr-3046.surge.sh The following output files are affected by this PR: |
a47af50
to
63322aa
Compare
guides/common/modules/proc_upgrading-a-connected-project-server.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the whole procedures more separate. For example, dnf -y module switch-to postgresql:13
doesn't work on EL9 because it ships PG 13 in the base. We also don't have the foreman:el8
module on EL9.
63322aa
to
173021e
Compare
It felt a bit verbose to copy / paste the upgrade bits and repeat them for EL8 and EL9, so I added some "if" conditionals for EL 8 users. If anyone has a suggestion for a neat way to separate them even more, let me know via a change request. |
173021e
to
d948f70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In itself this is correct and improves it.
d948f70
to
5e7d885
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks.
guides/common/modules/proc_upgrading-a-connected-project-server.adoc
Outdated
Show resolved
Hide resolved
5e7d885
to
f6c53a3
Compare
@Lennonka I fixed the issues you found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more structural suggestion.
. On {EL} 9: Update repositories: | ||
+ | ||
[options="nowrap" subs="attributes"] | ||
---- | ||
ifdef::katello[] | ||
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm \ | ||
https://yum.theforeman.org/katello/{KatelloVersion}/katello/el9/x86_64/katello-repos-latest.rpm | ||
endif::[] | ||
ifdef::foreman-el[] | ||
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm | ||
endif::[] | ||
---- | ||
. On {EL} 8: Update repositories: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. On {EL} 9: Update repositories: | |
+ | |
[options="nowrap" subs="attributes"] | |
---- | |
ifdef::katello[] | |
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm \ | |
https://yum.theforeman.org/katello/{KatelloVersion}/katello/el9/x86_64/katello-repos-latest.rpm | |
endif::[] | |
ifdef::foreman-el[] | |
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm | |
endif::[] | |
---- | |
. On {EL} 8: Update repositories: | |
. Update repositories: | |
* On {EL} 9: | |
+ | |
[options="nowrap" subs="attributes"] | |
---- | |
ifdef::katello[] | |
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm \ | |
https://yum.theforeman.org/katello/{KatelloVersion}/katello/el9/x86_64/katello-repos-latest.rpm | |
endif::[] | |
ifdef::foreman-el[] | |
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm | |
endif::[] | |
---- | |
* On {EL} 8: |
This structure would be a bit less prone to oversights.
. On {EL} 9: Update repositories: | ||
+ | ||
[options="nowrap" subs="attributes"] | ||
---- | ||
ifdef::katello[] | ||
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm \ | ||
https://yum.theforeman.org/katello/{KatelloVersion}/katello/el9/x86_64/katello-repos-latest.rpm | ||
endif::[] | ||
ifdef::foreman-el[] | ||
# {project-package-update} https://yum.theforeman.org/releases/{ProjectVersion}/el9/x86_64/foreman-release.rpm | ||
endif::[] | ||
---- | ||
. On {EL} 8: Update repositories: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly here.
@ianballou Can you please take a look at this? |
f6c53a3
to
207e814
Compare
207e814
to
6ba9955
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supergreen!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ian, LGTM.
There may be more spots that need EL9.