-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform health check before restore #3066
base: master
Are you sure you want to change the base?
Perform health check before restore #3066
Conversation
The PR preview for f3e7e07 is available at theforeman-foreman-documentation-preview-pr-3066.surge.sh The following output files are affected by this PR: |
Honest question: why not? Things are going to be wiped anyway. |
I had a user report that things "did not go according to plan" when they tried to restore their backup on an already broken/not running smoothly Foreman/Katello instance. Therefore, I suggest that they perform a health check before restoring from backup. |
I share @evgeni's concerns. Today's installation may be broken, but the restore may fix that. Also, if it fails, what action does the user have? |
I think it's a bit of a mixed bag. |
Fair point. Is there any resource to know "how much" your instance can be broken and you'll still be able to fix it by restoring a backup? Maybe a health check is too rigid, but maybe you expect at least a function "foreman-maintain" and/or "foreman-installer"? |
Often the only way to know that is to run it. We usually don't have a good way to detect why something is broken. |
I don't think we have that, no |
I am unsure if the current docs make sense:
Do we support restoring from backup on a used/slightly broken F+K instance? Or is it officially only supported to restore from backup on a freshly installed F+K instance? Do you have any suggestions @apinnick ? |
@maximiliankolb Sorry, but I cannot comment on this. I do not know enough about the health check or restore process. |
@maximiliankolb do you have any more insight what the user meant by "did not go according to plan"? If they know what was broken, we could add checks for that, but generally speaking we (as in the team who maintains the backup/restore tooling) expect a "dirty" machine to be sufficient for a restore |
users should not (try to) restore to a Foreman/Katello instance that is not running smoothly.
Please cherry-pick my commits into: