Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform health check before restore #3066

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maximiliankolb
Copy link
Contributor

users should not (try to) restore to a Foreman/Katello instance that is not running smoothly.

Please cherry-pick my commits into:

  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8)

@ekohl ekohl requested a review from evgeni June 6, 2024 11:53
@evgeni
Copy link
Member

evgeni commented Jun 6, 2024

Honest question: why not? Things are going to be wiped anyway.

@maximiliankolb
Copy link
Contributor Author

Honest question: why not? Things are going to be wiped anyway.

I had a user report that things "did not go according to plan" when they tried to restore their backup on an already broken/not running smoothly Foreman/Katello instance. Therefore, I suggest that they perform a health check before restoring from backup.

@ekohl
Copy link
Member

ekohl commented Jun 6, 2024

I share @evgeni's concerns. Today's installation may be broken, but the restore may fix that. Also, if it fails, what action does the user have?

@evgeni
Copy link
Member

evgeni commented Jun 6, 2024

I think it's a bit of a mixed bag.
If you broke your install by dropping a db or deleting var lib pulp, health check will be unhappy but restore will work fine (and is expected to, IMHO). But there are certainly ways to break a system where a plain restore won't work and will require a clean system to continue.

@maximiliankolb
Copy link
Contributor Author

Fair point. Is there any resource to know "how much" your instance can be broken and you'll still be able to fix it by restoring a backup?

Maybe a health check is too rigid, but maybe you expect at least a function "foreman-maintain" and/or "foreman-installer"?

@ekohl
Copy link
Member

ekohl commented Jun 6, 2024

Often the only way to know that is to run it. We usually don't have a good way to detect why something is broken.

@evgeni
Copy link
Member

evgeni commented Jun 6, 2024

I don't think we have that, no

@maximiliankolb
Copy link
Contributor Author

I am unsure if the current docs make sense:

  • there is a requirement to "choose the appropriate X.Y version"
  • we tell the user to "installing Foreman/Katello" as part of the procedure

Do we support restoring from backup on a used/slightly broken F+K instance? Or is it officially only supported to restore from backup on a freshly installed F+K instance?

Do you have any suggestions @apinnick ?

@apinnick
Copy link
Contributor

apinnick commented Jun 9, 2024

I am unsure if the current docs make sense:

* there is a requirement to "choose the appropriate X.Y version"

* we tell the user to "installing Foreman/Katello" as part of the procedure

Do we support restoring from backup on a used/slightly broken F+K instance? Or is it officially only supported to restore from backup on a freshly installed F+K instance?

Do you have any suggestions @apinnick ?

@maximiliankolb Sorry, but I cannot comment on this. I do not know enough about the health check or restore process.

@maximiliankolb maximiliankolb marked this pull request as draft June 10, 2024 14:02
@evgeni
Copy link
Member

evgeni commented Jun 12, 2024

@maximiliankolb do you have any more insight what the user meant by "did not go according to plan"? If they know what was broken, we could add checks for that, but generally speaking we (as in the team who maintains the backup/restore tooling) expect a "dirty" machine to be sufficient for a restore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants