-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix x.y.z version terminology #3121
Fix x.y.z version terminology #3121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I found another instance of "z-stream": https://docs.theforeman.org/nightly/Planning_for_Project/index-katello.html#glossary-of-terms-used-in-foreman_planning |
guides/common/modules/con_updating-project-to-next-patch-version.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_updating-project-to-next-patch-version.adoc
Outdated
Show resolved
Hide resolved
I've updated the Glossary as well. |
This comment was marked as outdated.
This comment was marked as outdated.
53253e4
to
7f59a86
Compare
Rebased. |
7f59a86
to
adfa02e
Compare
@maximiliankolb Will do the honor of signing it off? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and matches https://semver.org/
Should I cherry-pick this or not? I'm still not sure. @maximiliankolb @ekohl |
@Lennonka cherry-picking to 3.11 would be good for me but I have no strong opinion. |
* Fix version terminology * Fix version names * Turn recommendation into admonition * Fix release level (cherry picked from commit 11c87e1)
It must be confusing that we call z-stream "minor version" when it should be called "patch version". This has been bugging me for quite some time.
Please cherry-pick my commits into: