Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify enable and sync the Client repo for Satellite #3133

Merged
merged 7 commits into from
Jul 20, 2024
Merged

Simplify enable and sync the Client repo for Satellite #3133

merged 7 commits into from
Jul 20, 2024

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Jul 15, 2024 •
edited

I think that it's enough to only give generic hints to the user instead of providing a procedure for each RHEL version. Additionally, the repo is provided also for other architectures than just x86_64. I was hoping to provide a table of all Satellite Client 6 repo variants, however, this list is much longer than I anticipated (see the first comment). In the end, I decided to leave the repo names out altogether.

I've also decided not to include CLI procedures, because the naming of the repositories and architectures is inconsistent. I wouldn't recommend to do these tasks in the CLI, because the CLI by itself doesn't provide sufficient data to support it. However, if we would be okay with x86_64 arch as an example, I'm happy to re-add the CLI procedures.

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into: no cherry-picks

@Lennonka
Copy link
Contributor Author

Lennonka commented Jul 15, 2024 •
edited

Consider this list of all available Client repos (to get an idea):

# hammer repository-set list --organization "Default Organization" --search "Satellite Client" \
--fields name | grep "(RPMs)" | grep "Satellite Client"

Red Hat Satellite Client 6 (for RHEL 6 for System Z - ELS) (RPMs)                                           
Red Hat Satellite Client 6 (for RHEL 6 Server - ELS) (RPMs)                                                 
Red Hat Satellite Client 6 (for RHEL 7 Desktop) (RPMs)                                                      
Red Hat Satellite Client 6 (for RHEL 7 for IBM Power LE) (RPMs)                                             
Red Hat Satellite Client 6 (for RHEL 7 for IBM Power LE - Update Services for SAP Solutions) (RPMs)         
Red Hat Satellite Client 6 (for RHEL 7 for IBM Power) (RPMs)                                                
Red Hat Satellite Client 6 (for RHEL 7 for Scientific Computing) (RPMs)                                     
Red Hat Satellite Client 6 (for RHEL 7 for System Z) (RPMs)                                                 
Red Hat Satellite Client 6 (for RHEL 7 Server - AUS) (RPMs)                                                 
Red Hat Satellite Client 6 (for RHEL 7 Server) (RPMs)                                                       
Red Hat Satellite Client 6 (for RHEL 7 Server - TUS) (RPMs)                                                 
Red Hat Satellite Client 6 (for RHEL 7 Server - Update Services for SAP Solutions) (RPMs)                   
Red Hat Satellite Client 6 (for RHEL 7 Workstation) (RPMs)                                                  
Red Hat Satellite Client 6 for RHEL 8 aarch64 (RPMs)                                                        
Red Hat Satellite Client 6 for RHEL 8 IBM z Systems - Extended Update Support (RPMs)                        
Red Hat Satellite Client 6 for RHEL 8 Power, little endian - Extended Update Support (RPMs)                 
Red Hat Satellite Client 6 for RHEL 8 Power, little endian - Update Services for SAP Solutions (RPMs)       
Red Hat Satellite Client 6 for RHEL 8 ppc64le (RPMs)                                                        
Red Hat Satellite Client 6 for RHEL 8 s390x (RPMs)                                                          
Red Hat Satellite Client 6 for RHEL 8 x86_64 - Advanced Mission Critical Update Support (RPMs)              
Red Hat Satellite Client 6 for RHEL 8 x86_64 - Extended Update Support (RPMs)                               
Red Hat Satellite Client 6 for RHEL 8 x86_64 (RPMs)                                                         
Red Hat Satellite Client 6 for RHEL 8 x86_64 - Telecommunications Update Service (RPMs)                     
Red Hat Satellite Client 6 for RHEL 8 x86_64 - Update Services for SAP Solutions (RPMs)                     
Red Hat Satellite Client 6 for RHEL 9 aarch64 (RPMs)                                                        
Red Hat Satellite Client 6 for RHEL 9 IBM z Systems - Extended Update Support (RPMs)                        
Red Hat Satellite Client 6 for RHEL 9 Power, little endian - Extended Update Support (RPMs)                 
Red Hat Satellite Client 6 for RHEL 9 Power, little endian - Update Services for SAP Solutions (RPMs)       
Red Hat Satellite Client 6 for RHEL 9 ppc64le (RPMs)                                                        
Red Hat Satellite Client 6 for RHEL 9 s390x (RPMs)                                                          
Red Hat Satellite Client 6 for RHEL 9 x86_64 - Advanced Mission Critical Update Support (RPMs)              
Red Hat Satellite Client 6 for RHEL 9 x86_64 - Extended Update Support (RPMs)                               
Red Hat Satellite Client 6 for RHEL 9 x86_64 (RPMs)                                                         
Red Hat Satellite Client 6 for RHEL 9 x86_64 - Update Services for SAP Solutions (RPMs)

The user will probably see a smaller set depending on their purchased subscription.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited

The PR preview for 0f5abfe is available at theforeman-foreman-documentation-preview-pr-3133.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@Lennonka Lennonka mentioned this pull request Jul 15, 2024
Closed
9 tasks
@Lennonka Lennonka force-pushed the simplify-enable-sync-client-repo branch from 9fa391d to 90a0771 Compare July 15, 2024 22:50
maximiliankolb
maximiliankolb reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments; please also delete unused modules from guides/common/assembly_enabling-and-synchronizing-the-project-client-name-repository.adoc; rest LGTM.

guides/common/modules/con_importing-the-project-client-name-repository.adoc Outdated Show resolved Hide resolved
guides/common/assembly_importing-the-project-client-name-repository.adoc Show resolved Hide resolved
@Lennonka
Copy link
Contributor Author

Lennonka commented Jul 16, 2024 •
edited

@maximiliankolb The assembly is included only for Satellite, so there's no need for additional conditions.

I've removed the unused files, thank you for the reminder!

@Lennonka Lennonka force-pushed the simplify-enable-sync-client-repo branch from 969e4e0 to 1c92488 Compare July 16, 2024 18:09
@Lennonka Lennonka force-pushed the simplify-enable-sync-client-repo branch from 5e464e0 to 0f5abfe Compare July 16, 2024 22:53
@Lennonka
Copy link
Contributor Author

I had to add a new solution using ISS for the disconnected env, because RH CP doesn't provide ISOs for this repo.

maximiliankolb
maximiliankolb approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM.

Not blocking your PR: I wonder why we don't include these procedures for Katello and orcharhino. With a tiny adjustment about the delivered packages in the Client repo, we could probably make this work in a future PR.

@Lennonka
Copy link
Contributor Author

Lennonka commented Jul 17, 2024 •
edited

@maximiliankolb There's a huge mess in Installing guides for upstream if you meant including it there. 😆

@maximiliankolb
Copy link
Contributor

@maximiliankolb There's a huge mess in Installing guides for upstream if you meant including it there. 😆

Thanks for the warning ... then I won't try. :D

@Lennonka Lennonka merged commit 620b1bd into theforeman:master Jul 20, 2024
8 checks passed
@Lennonka Lennonka deleted the simplify-enable-sync-client-repo branch July 20, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lennonka @maximiliankolb