Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Product, Ansible Playbook to Contributing #3134

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add Product, Ansible Playbook to Contributing #3134

merged 1 commit into from
Jul 17, 2024

Conversation

apinnick
Copy link
Contributor

@apinnick apinnick commented Jul 16, 2024 •
edited

Add "Product" and "Ansible Playbook" to Capitalization section of Contributing.md

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

@apinnick
Add Product, Ansible Playbook to Contributing
bf3de35 
Add "Product" and "Ansible Playbook" to Capitalization section of Contributing.md
@apinnick apinnick marked this pull request as ready for review July 16, 2024 09:23
@apinnick apinnick mentioned this pull request Jul 16, 2024
Merged
9 tasks
@github-actions GitHub Actions
Copy link

The PR preview for bf3de35 is available at theforeman-foreman-documentation-preview-pr-3134.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

maximiliankolb
maximiliankolb approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd like one or two more ACKs on "Product" similar to our Matrix chat.

cc @Lennonka @asteflova

Lennonka
Lennonka approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK :)

@maximiliankolb maximiliankolb merged commit 7c51cca into theforeman:master Jul 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb approved these changes

@Lennonka Lennonka Lennonka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apinnick @maximiliankolb @Lennonka