-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rpm repo profile #2118
Add rpm repo profile #2118
Conversation
f6e4a4d
to
a8989ef
Compare
@@ -0,0 +1,3 @@ | |||
<h1>Pulpcore packages</h1> | |||
|
|||
These are RPM builds for <a href="https://pulpproject.org">Pulp 3</a> and various plugins for use by <a href="https://theforeman.org/plugins/katello/">Katello</a>. They are only intended to be used by Katello. Only branches used by Katello are maintained. No explicit end of life announcements will be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also link to https://github.com/theforeman/forklift/blob/master/vagrant/config/versions.yaml to figure out that mapping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should try to display this mapping on https://theforeman.github.io/foreman-plugin-overview/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an interesting thought I hadn't considered. The URL might need to be changed to match the title (Foreman landscape) to reflect the broader scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was recently talking to @archanaserver and she also expressed confusion that this important information is so well hidden in a config file in some almost random repo.
So yeah, big 👍 on exposing that data somewhere in a nice way, but obviously shouldn't block this PR.
14877f8
to
e5d0a15
Compare
d48916b
to
a4d0d27
Compare
If we look at the structure (from #1937):
Given we won't have per katello-version repositories, I wonder if having a Katello repository makes sense. Let's look at what is in the Katello repo:
I believe the three primary reasons we keep Katello separate today:
I think the first point is not such a problem anymore, and could be reduced further through meta RPM elimination (perhaps through single scenario per installer RPM change). We could start signing plugins as we've discussed. The pipelines part we've discussed and never arrived at a good answer for. So perhaps doing it through release RPMs is the easiest. And we can simplify a bit at least by aligning GPG signing key with this structure. |
a4d0d27
to
8635816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mind dropping the specific katello repository. It does mean some additional preparation like updating procedures in theforeman-rel-eng and some RPMs, but it would resolve a long standing issue.
878d82b
to
8ef2abf
Compare
I am feeling good about this and think it's ready for merge an getting applied to the host so that I can proceed with additional testing and updates. |
8ef2abf
to
524eca2
Compare
Based on conversation here -- #1937 (comment) I would like to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, but I think we can start rolling out the machine to experiment with. Then from there we can write up the exact migration plan.
@@ -241,3 +242,14 @@ sudo::wheel_config: password | |||
redmine::https: true | |||
|
|||
apache::default_vhost: false | |||
|
|||
rsync_usernames: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have added a comment, but I started this file with custom definitions first. Then around like 12 I started to map things. With the introduction of stable_release
I think that already broke (and I should have noticed it there).
My question: how should we manage this? Do we want to keep things that we regularly change (i.e., real data) at the top while keeping more "internals" near the bottom or keep them close to each other since they're closely connected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split it into two files? That would be easier for me to understand. And I imagine be more obvious to newcomers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two files sounds good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to treat this as a follow up and merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented this idea here
524eca2
to
796a1b4
Compare
This is to provide the code to match the structure -- #1937