Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #25839 - Avoid storing puppetserver related versions #311

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Refs #25839 - Avoid storing puppetserver related versions #311

merged 1 commit into from
Jan 11, 2019

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jan 11, 2019

ehelms
ehelms approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the puppet-puppet change

@mmoll
Copy link
Contributor

mmoll commented Jan 11, 2019

@ekohl tests need updating I guess?

@ekohl
Copy link
Member Author

ekohl commented Jan 11, 2019

I've changed the migrations to only wipe it if the key is present. This fixes the tests

@mmoll mmoll merged commit e231869 into theforeman:develop Jan 11, 2019
@mmoll
Copy link
Contributor

mmoll commented Jan 11, 2019

merged bedankt @ekohl!

@ekohl ekohl deleted the 25839-puppetserver-version branch January 11, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekohl @mmoll @ehelms @theforeman-bot