Add rubygem-sidekiq{,-reliable-fetch} #4188
Conversation
adamruzicka
changed the title
adamruzicka
force-pushed
the
rpm/develop-sidekiq
branch
from
9db6804 to
1be198d
Compare
|
You'll want to regenerate these using the scl gem2rpm template. |
adamruzicka
force-pushed
the
rpm/develop-sidekiq
branch
from
1be198d to
347ad51
Compare
|
Regenerated |
|
[test rpm] |
packages/foreman/rubygem-gitlab-sidekiq-fetcher/rubygem-gitlab-sidekiq-fetcher.spec
Show resolved
Hide resolved
|
you probably need to update comps/ and rel-eng/tito.props too! |
| <packagereq type="default">nodejs-expose-loader-doc</packagereq> | ||
| <packagereq type="default">nodejs-file-loader-doc</packagereq> | ||
| <packagereq type="default">nodejs-jquery-doc</packagereq> | ||
| <packagereq type="default">nodejs-jquery-flot-doc</packagereq> | ||
| <packagereq type="default">nodejs-select2-doc</packagereq> |
There was a problem hiding this comment.
This was done by comps_doc.sh, should I put those back?
There was a problem hiding this comment.
We dropped various packages but probably didn't regenerate the comps file. Probably cleanest to fix this in rpm/develop and rebase this PR on it.
|
not sure what that error actually means... [test rpm] |
|
@ekohl any idea about this failure? It looks like the git annex whereis is failing, but it thinks the sources are already downloaded, i've never seen that before. |
adamruzicka
force-pushed
the
rpm/develop-sidekiq
branch
2 times, most recently
from
f80f66c to
85cc6d8
Compare
|
And we're 🍏 |
There is sidekiq-reliable-fetch and gitlab-sidekiq-fetcher, I somehow mixed the two.
adamruzicka
force-pushed
the
rpm/develop-sidekiq
branch
from
ef93efd to
518b307
Compare
|
Is now based on #4195 |
|
@adamruzicka #4195 is in, could you rebase again? |
| %{gem_instdir}/Pro-4.0-Upgrade.md | ||
| %{gem_instdir}/Pro-Changes.md | ||
| %{gem_instdir}/bin | ||
| %{gem_instdir}/code_of_conduct.md |
There was a problem hiding this comment.
The md files should probably have %doc on them, and the 'dot' files should probably have %exclude
There was a problem hiding this comment.
Should all the md files go into the doc package?
There was a problem hiding this comment.
Probably. We should update our gem2rpm template since I've seen a few more of those.
| %files | ||
| %dir %{gem_instdir} | ||
| %exclude %{gem_instdir}/.gitignore | ||
| %{gem_instdir}/.gitlab-ci.yml |
No description provided.