Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubygem-logging to 2.3.0 #5666

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

lzap
Copy link
Member

@lzap lzap commented Aug 12, 2020

For plugin updates, please indicate which repos this should be built into:

  • Nightly

This fixes one synchronization issue we are running into in smart proxy
and dynflow. @adamruzicka

TwP/logging#219

@adamruzicka
Copy link

This fixes one synchronization issue we are running into in smart proxy and dynflow.

Oh yes, finally 🎉 Thank you

You will probably need to add rubygem-logging to package_manifest.yaml to make the build pass

@lzap
Copy link
Member Author

lzap commented Aug 12, 2020

You will probably need to add rubygem-logging to package_manifest.yaml to make the build pass

Ok thanks for heads up.

@lzap lzap force-pushed the rpm/develop-logging230 branch from 998ea97 to 4cbea54 Compare August 12, 2020 12:25
@adamruzicka
Copy link

This is just a wild guess, but maybe little-plugger and multi_json need to be there as well?

@lzap lzap force-pushed the rpm/develop-logging230 branch from 4cbea54 to 077c016 Compare August 31, 2020 12:49
@lzap
Copy link
Member Author

lzap commented Aug 31, 2020

Logs are gone, these are not new dependencies. Not sure what was wrong. Rebased.

@lzap lzap closed this Sep 7, 2020
@lzap lzap deleted the rpm/develop-logging230 branch September 7, 2020 09:39
@lzap lzap restored the rpm/develop-logging230 branch September 10, 2020 14:22
@lzap
Copy link
Member Author

lzap commented Sep 10, 2020

I am not aware closing and deleting the branch myself. Reopening.

@lzap lzap reopened this Sep 10, 2020
@lzap lzap force-pushed the rpm/develop-logging230 branch from 077c016 to 0c5b7dc Compare September 17, 2020 06:02
@lzap
Copy link
Member Author

lzap commented Sep 17, 2020

Rebased, hopefully I can see what's wrong now.

@lzap
Copy link
Member Author

lzap commented Sep 22, 2020

I've added little-plugger to the YAML, however I do see multi_json already there:

[2020-09-17T06:06:22.904Z]     Added downloaded_rpms repo from ./downloaded_rpms/rhel7
[2020-09-17T06:06:22.904Z]     package: rubygem-logging-2.3.0-1.el7.noarch from downloaded_rpms
[2020-09-17T06:06:22.904Z]       unresolved deps:
[2020-09-17T06:06:22.904Z]         rubygem(little-plugger) >= 1.1
[2020-09-17T06:06:22.904Z]         rubygem(little-plugger) < 2
[2020-09-17T06:06:22.904Z]         rubygem(multi_json) >= 1.10

Not sure why it appears there, it's whitelisted in tito.props as well. Anyone?

@evgeni
Copy link
Member

evgeni commented Sep 22, 2020

@lzap that's because it still built it for non-scl, #5835 should fix that

@evgeni
Copy link
Member

evgeni commented Sep 22, 2020

my PR also includes your manifest change (as it was incomplete), please rebase when it's merged

@ekohl
Copy link
Member

ekohl commented Sep 22, 2020

It was merged. Please rebase.

@lzap lzap force-pushed the rpm/develop-logging230 branch from 34ff83d to 10bea46 Compare September 22, 2020 11:57
@lzap
Copy link
Member Author

lzap commented Sep 22, 2020

Thank you so much! Rebased.

@evgeni evgeni merged commit 5a3ce84 into theforeman:rpm/develop Sep 22, 2020
@lzap lzap deleted the rpm/develop-logging230 branch September 22, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants