-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubygem-logging to 2.3.0 #5666
Conversation
Oh yes, finally 🎉 Thank you You will probably need to add rubygem-logging to package_manifest.yaml to make the build pass |
Ok thanks for heads up. |
998ea97
to
4cbea54
Compare
This is just a wild guess, but maybe |
4cbea54
to
077c016
Compare
Logs are gone, these are not new dependencies. Not sure what was wrong. Rebased. |
I am not aware closing and deleting the branch myself. Reopening. |
077c016
to
0c5b7dc
Compare
Rebased, hopefully I can see what's wrong now. |
I've added little-plugger to the YAML, however I do see multi_json already there:
Not sure why it appears there, it's whitelisted in tito.props as well. Anyone? |
0c5b7dc
to
34ff83d
Compare
my PR also includes your manifest change (as it was incomplete), please rebase when it's merged |
It was merged. Please rebase. |
34ff83d
to
10bea46
Compare
Thank you so much! Rebased. |
For plugin updates, please indicate which repos this should be built into:
This fixes one synchronization issue we are running into in smart proxy
and dynflow. @adamruzicka
TwP/logging#219