-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37496 - RHEL registration template prioritizes paramaters #10188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, it does make sense. We should allow users to override the output of the template by host parameters, but I'll leave the final ACK to @nofaralfasi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nofaralfasi is on PTO for this week, but it makes sense to me too. Shall we just merge it now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@aburhinox could you rephrase the the commit message to fit our convention? I also don't know why CI didn't run, so updating your commit may also solve that. |
502d83a
to
bf94b04
Compare
Thanks for taking a look at this. I believe I followed the commit message guidance I found https://theforeman.org/handbook.html but it's still failing the automated tests. Can anyone help point out what is wrong with the commit message? I have the redmine number, added the short description, and have slightly longer description below, not sure why it's failing. |
Changed priority on subman_org to use host_parm if present, then use katello generated org
bf94b04
to
4a00329
Compare
thanks @stejskalleos, that did the trick. it looks like it's in good condition to review now. |
Thanks @aburhinox |
Fixes #37496
This changes the priority on subman_org to use host_parm if present, then use katello generated org. This will allow users to override the katello generated org through a host_parm, and if not present continue to work as today with the katello generated org.