Fixes #37602 - Don't validate medium for unmanaged hosts

[sbernhard]

See https://projects.theforeman.org/issues/37602 for full issue description.

[stejskalleos]

I don't think this is the way we want to go, creating OS is part of the registration and disabling it is against user experience IMO.

This will create an OS inForemann, but this new OS doesn’t have the installation media assigned (because it is a new OS)

What kind of OS is that? Can we create a default installation medium for it inForemann, the same way we do for other operating systems?

[sbernhard]

To create default installation media doesn't help @stejskalleos. As described in https://projects.theforeman.org/issues/37602 for every OS a major.minor is created. Liked Alma Linux 8.10. So, if you want to maintain AlmaLinux, OracleLinux and RockyLinux it would create 10 different minor versions (Alma 8.1, 8.2 .... 8.10) for each OS which would be somehow a mess.

Is this the same for RHEL or are the RHEL Major.Minor version somehow auto-generated?

Therefore the idea is, to re-use the operating system which is configured for the Hostgroup. Of course it would be possible to have this feature as a option.

[sbernhard]

Important

I have implemented a different approach which should solve the issue. During host registration the hosts are created as "unmanaged" hosts. In the UI the Operatingsystem tab in the Hosts Edit View is hidden. Therefore, don't run the medium validations.

[jeremylenz]

@ianballou Any concerns here in light of Katello/katello#11049 ?

[ekohl]

Isn't this redundant? validate_media? already checks for managed:

foreman/app/models/host/managed.rb

Lines 747 to 749 in e78bd15

	def validate_media?
	managed && !image_build? && build?
	end

[sbernhard]

Thanks @ekohl Good catch. I was actually mainly testing https://github.com/theforeman/foreman/pull/10226/files#diff-b7f82bd4fe3d5a5a8b246f502ab1e894197164cf7bf48fbfd5c2f3d76da2362eL326 and thought its also a good idea to have the managed? check for this part, too.

[ekohl]

See https://projects.theforeman.org/issues/37602 for full issue description.

Please also include a description of why you make a change in the actual commit message. I still consider https://cbea.ms/git-commit/ as a must read.

Note that Redmine is useful, but a bug report is often different than the change itself. That describes to future developers why a code change was made.

I have implemented a different approach which should solve the issue. During host registration the hosts are created as "unmanaged" hosts. In the UI the Operatingsystem tab in the Hosts Edit View is hidden. Therefore, don't run the medium validations.

It's correct that unmanaged hosts don't have certain fields. You can see we hide those in the host form:

foreman/app/views/hosts/_form.html.erb

Lines 13 to 18 in e78bd15

	<% if @host.managed %>
	<% if authorized_for(:controller => "Compute::Resources::Vms", :action => :create) %>
	<li id="compute_resource_tab" <%= display? !(@host.compute_resource_id || params[:host] && params[:host][:compute_resource_id].present?)%>><a href="#compute_resource" data-toggle="tab"><%= _('Virtual Machine') %></a></li>
	<% end %>
	<li><a href="#os" data-toggle="tab"><%= _('Operating System') %></a></li>
	<% end %>

foreman/app/views/hosts/_form.html.erb

Line 106 in e78bd15

<%= render('hosts/unattended', :f => f) if @host.managed %>

That latter is:

foreman/app/views/hosts/_unattended.html.erb

Lines 1 to 7 in e78bd15

	<div class="tab-pane" id="compute_resource">
	<%= render('hosts/compute', host: @host, vm: @vm, compute_resource: @host.compute_resource) if @host.compute_resource %>
	</div>
	<div class="tab-pane" id="os">
	<%= render 'hosts/operating_system', :host => @host, :f => f %>
	</div>

And that refers to https://github.com/theforeman/foreman/blob/develop/app/views/hosts/_operating_system.html.erb

And I think the medium is only used when the provision method is build.

So really, it's even more nuanced.

[ekohl]

Is this really correct? If it's unmanaged, why does it even have a medium in the first place? And if it doesn't have a medium, the check isn't blocking.

IMHO that's really the root cause: somehow the host is getting a medium assigned that's invalid for the operating system. We should not do that.

Perhaps this is a bug in the inheritance from a hostgroup?

[sbernhard]

A host was registered using HostRegistartion. During this process, a Hostgroup was used and assigned to the host.
For this Hostgroup the Installation Media was configured.

The host is using the subscription-manager to register. This will create a new OS in foreman if the OS doesn't currently exist. This new OS doesn’t have the installation media assigned (because its a new OS).

Summary:

• The new created Operatingsystem like AlmaLinux9 doesn't have a Installation Media.
• The used Hostgroup has different Operatingsystems and is using a InstallationMedia which is valid for the Operatingsystem used in this Hostgroup.

The POST request during the HostRegistration process which assign Hostgroup to the Host and should render the host_init_config Template will fail with:

The system has been registered with ID: 21312a8f-1b6e-4302-ae9e-1a64b643c6f8
The registered system name is: myra-bergh.master.dev.atix
ERROR: Validation failed: Medium must belong to host's operating system

Notice:

• if the Hostgroup doesn't have a Operatingsystem OR Installation Media > everything works
• If the Operatingsystem of the Host, is already configured on foreman, including valid Installatin Media -> everything works

[ianballou]

@ianballou Any concerns here in light of Katello/katello#11049 ?

No concerns from the kickstart repo side, this change would only make it less likely for hosts to hit the medium validation issue.

[sbernhard]

Obsoleted by #10246