Fixes #37647 - Make telemetry allowed_labels configurable

[pmoravec]

It might not be the best idea to put the lengthy list of classes to settings.yaml. As the list contains majority of classes either way, maybe we can have there simply:

:class:
 - '.*'

?

[ekohl]

I think we shouldn't require those values to always be present in settings.yaml but rather have a hard coded default. We do that in config/settings.rb.

[pmoravec]

I think we shouldn't require those values to always be present in settings.yaml but rather have a hard coded default. We do that in config/settings.rb.

Good point. And we should allow to configure either :controller or :action or :class independently. Like allow in config:

:allowed_labels:
  :class:
   - '.*'

that will update just the classes.

I will update PR accordingly.

[ekohl]

Note this is a merge, not a deep merge. So it replaces all keys. Did you intend:

Suggested change

	allowed_labels.merge!(SETTINGS[:telemetry][:allowed_labels]) if SETTINGS[:telemetry] and SETTINGS[:telemetry][:allowed_labels]
	allowed_labels.deep_merge!(SETTINGS[:telemetry][:allowed_labels]) if SETTINGS.dig(:telemetry, :allowed_labels)

[pmoravec]

Good points, I am still ruby newbie :)

[pmoravec]

I think the failing test:functionals are independent on my PR.

[ekohl]

Correct, I just restarted those tests because it should have been fixed.