Fixes #38037 - Update last login time for External Auth user

[hao-yu]

This bug1 has been reported previously in Satellite 6.2 and fixed in Satellite 6.3

 [1] https://bugzilla.redhat.com/show_bug.cgi?id=1460963

Later on it broke again by the PR below 5 years ago:

https://github.com/theforeman/foreman/pull/7155/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6eL201

[sjha4]

The code looks logical to me as in calling the post_login method before redirecting.. I took some help from QE to test it and am not sure if the issue is reproducible though.

[vsedmik]

I'm not sure if I completely understand the issue here, but looking at the fix it seems @hao-yu is just moving the user.post_successful_login from extlogin to login_user(user). So is the issue we are trying to solve here the Last login time not being updated when we log in via WebUI using the AD credentials? Because when I log in using kinit the Last login time gets updated just ok (~ I could not reproduce the issue).

Also I wonder if we need to keep user.post_successful_login at both places to get the time updated no matter how we log in (via kinit or WebUI) or if keeping it only in login_user(user) works just fine for both?

I'm sorry for my ignorance, not an expert here, I just got somehow curious about this one.

Thank you!

[adamruzicka]

In general, this seems to resolve the issue, but it would be nice if we could avoid updating the time twice for internal users.

What I tested:

• Logging in as internal user through UI - this behaves worse with this patch
• Making api requests as internal user - this behaves the same
• Logging in as external user through UI - this behaves better - the time is updated exactly once
• Creating a session as an external user with hammer - this behaves better - the time is updated exactly once

Sort of unrelated note:
When making API requests as an internal user, user.post_successful_login is called twice, but this is not introduced by this patch.

[adamruzicka]

With this change, this gets called twice when logging to the UI as an internal user, once from the depths of User.try_to_login on L127 and second time from here by calling login_user on L143.

[hao-yu]

After this patch, I also notice that user.post_successful_login is also called twice when the external user login successfully for the first time after auto create user in find_or_create_external_user.

This change seems better?

diff --git a/app/models/user.rb b/app/models/user.rb
index a8ca2a1ae..639029c3f 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -337,6 +337,7 @@ class User < ApplicationRecord
         user.usergroups = new_usergroups.uniq
       end
 
+      user.post_successful_login
       user
     # not existing user and creating is disabled by settings
     elsif auth_source_name.nil?