Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #38154 - Allow generic table children outside of tbody #10419

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fixes #38154 - Allow generic table children outside of tbody #10419

merged 1 commit into from
Jan 24, 2025
+36 −27

Conversation

MariaAga
Copy link
Member

For expandable rows, each child needs to be a tbody, tbody cant be the child of another tbody. A table can have multiple tbody s

@github-actions github-actions bot added the UI label Jan 21, 2025
@MariaAga MariaAga mentioned this pull request Jan 21, 2025
Merged
sjha4
sjha4 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the code, we shouldn't see any impacts on Katello given default for childrenOutsideTbody is false and katello components don't use this on existing pages. Plugin tests are green.. ✅

@adamruzicka adamruzicka merged commit 74ddd88 into theforeman:develop Jan 24, 2025
39 checks passed
@adamruzicka
Copy link
Contributor

Thank you @MariaAga & @sjha4 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjha4 sjha4 sjha4 approved these changes

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MariaAga @adamruzicka @sjha4