Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #19506 - reset cache after CR update #4524

Merged
merged 1 commit into from
May 11, 2017
Merged

Fixes #19506 - reset cache after CR update #4524

merged 1 commit into from
May 11, 2017

Conversation

ares
Copy link
Member

@ares ares commented May 10, 2017

No description provided.

@ares
Copy link
Member Author

ares commented May 10, 2017

actually this might desired only if the caching is enabled for the CR

@timogoebel
Copy link
Member

actually this might desired only if the caching is enabled for the CR

Yes. One more comment. Should the callback function always return true to not stop other callbacks from running?

@ares
Copy link
Member Author

ares commented May 11, 2017

Thanks @timogoebel, could you take another look please?

timogoebel
timogoebel approved these changes May 11, 2017
View reviewed changes
Copy link
Member

@timogoebel timogoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ares: Thanks. Will merge once tests pass.

@timogoebel timogoebel merged commit 67428d6 into theforeman:develop May 11, 2017
@timogoebel
Copy link
Member

Merged, thanks @ares.

@evgeni evgeni mentioned this pull request Oct 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timogoebel timogoebel timogoebel approved these changes

Assignees
No one assigned
Labels
Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ares @timogoebel @theforeman-bot