Translation improvements #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stejskalleos
commented
May 11, 2023
stejskalleos
commented
- Extract missing strings for the translations
- Fix interpolations in strings
- Update config for the transifex-cli
- Update *.po files
stejskalleos
force-pushed
the
ls/translate
branch
from
734ab4a to
babcb2b
Compare
chris1984
reviewed
May 15, 2023
There was a problem hiding this comment.
@stejskalleos everything looks fine, I noticed some translations are just coming back as "" I am thinking that is on Transifex though not having the translations available and not us.
Am I correct in that assumption?
Once I hear back I will merge
chris1984
added
Ready for Merge
and removed
Not yet reviewed
Waiting on contributor
labels
chris1984
reviewed
May 16, 2023
* Extract missing strings for the translations * Fix interpolations in strings * Update config for the transifex-cli * Update *.po files
stejskalleos
force-pushed
the
ls/translate
branch
from
d671006 to
58a5f13
Compare
Correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.