Add tests for upgrade scenario

.rubocop.yml

@@ -125,3 +125,6 @@ Style/StderrPuts:
 
 Metrics/ParameterLists:
   Max: 6
+
+Style/TrailingCommaInArguments:
+  Enabled: false

definitions/checks/foreman/check_corrupted_roles.rb

@@ -3,7 +3,7 @@ module Foreman
     class CheckCorruptedRoles < ForemanMaintain::Check
       metadata do
         label :corrupted_roles
-        for_feature :foreman_database
+        for_feature :foreman_server
         description 'Check for roles that have filters with multiple resources attached'
         tags :pre_upgrade
       end

definitions/checks/foreman/check_duplicate_permission.rb

@@ -3,7 +3,7 @@ module Foreman
     class CheckDuplicatePermissions < ForemanMaintain::Check
       metadata do
         label :duplicate_permissions
-        for_feature :foreman_database
+        for_feature :foreman_server
         description 'Check for duplicate permissions from database'
         tags :pre_upgrade
       end

definitions/checks/system_registration.rb

@@ -5,7 +5,7 @@ class Checks::SystemRegistration < ForemanMaintain::Check
     tags :default
 
     confine do
-      file_exists?('/etc/rhsm/rhsm.conf') && feature(:instance).downstream
+      feature(:instance).downstream
     end
   end
 

definitions/features/foreman_database.rb

@@ -35,7 +35,12 @@ def services
   private
 
   def load_configuration
-    config = YAML.load(File.read(FOREMAN_DB_CONFIG))
+    config = if File.exist?('/etc/foreman/database.yml')
+               YAML.load(File.read(FOREMAN_DB_CONFIG))
+             else
+               { 'production' => {} }
+             end
+
     @configuration = config['production']
     @configuration['host'] ||= 'localhost'
     @configuration

lib/foreman_maintain/concerns/base_database.rb

@@ -42,7 +42,7 @@ def configuration
       end
 
       def local?(config = configuration)
-        ['localhost', '127.0.0.1', `hostname`.strip].include? config['host']
+        ['localhost', '127.0.0.1', `hostname`.strip].include?(config['host'])
       end
 
       def query(sql, config = configuration)

lib/foreman_maintain/detector.rb

@@ -24,6 +24,7 @@ def refresh
       @all_features_scanned = false
       @available_checks = nil
       @available_scenarios = nil
+      @available_procedures = nil
       @scenarios ||= Scenario.all_sub_classes.select(&:autodetect?)
     end
 

test/definitions/assume_feature_dependencies_helper.rb

@@ -1,7 +1,14 @@
 module AssumeFeatureDependenciesHelper
   def assume_satellite_present(&block)
     PackageManagerTestHelper.assume_package_exist('satellite')
-    assume_feature_present(:satellite) unless block_given?
+    unless block_given?
+      assume_feature_present(:satellite)
+      assume_feature_present(:foreman_server)
+      assume_feature_present(:katello)
+      assume_feature_present(:candlepin)
+      assume_feature_present(:foreman_tasks)
+      assume_feature_present(:foreman_database)
+    end
     assume_feature_present(:satellite, &block)
   end
 end

test/definitions/checks/disk_performance_test.rb

@@ -8,6 +8,7 @@
   before do
     assume_feature_present(:pulpcore)
     check_disk_performance.stubs(:default_dirs).returns(:pulpcore => '/var/lib/pulp')
+    check_disk_performance.stubs(:debian_or_ubuntu?).returns(true)
   end
 
   it 'should confine existence of fio' do
@@ -18,7 +19,7 @@
   end
 
   it 'executes successfully for disk with minimal speed' do
-    assume_satellite_present
+    assume_feature_present(:satellite)
 
     check_disk_performance.stubs(:check_only_single_device?).returns(true)
 
@@ -37,7 +38,7 @@
   end
 
   it 'print warning if disk speed does not meet minimal requirement' do
-    assume_satellite_present
+    assume_feature_present(:satellite)
 
     slow_speed = 59
     err_msg = 'Slow disk'

test/definitions/procedures/restore/reindex_databases_test.rb

@@ -10,6 +10,7 @@
   before do
     assume_feature_present(:instance, :postgresql_local? => true)
     assume_feature_present(:foreman_database, :configuration => {})
+    Features::Service.any_instance.expects(:handle_services)
   end
 
   it 'reindexes all DBs if DB is local' do

test/definitions/scenarios/capsule_upgrade_test.rb

@@ -0,0 +1,168 @@
+require 'test_helper'
+
+describe "capsule upgrade scenarios" do
+  include DefinitionsTestHelper
+
+  before(:each) do
+    assume_feature_present(:capsule)
+    ForemanMaintain.config.stubs(:manage_crond).returns(true)
+  end
+
+  describe Scenarios::Satellite::PreUpgradeCheck do
+    let(:scenario) do
+      Scenarios::Satellite::PreUpgradeCheck.new
+    end
+
+    it 'composes all steps for Satellite on EL8' do
+      Scenarios::Satellite::PreUpgradeCheck.any_instance.stubs(:el_major_version).returns(8)
+
+      assert_scenario_has_steps(
+        scenario,
+        Checks::ServerPing,
+        Checks::ServicesUp,
+        Checks::SystemRegistration,
+        Checks::CheckHotfixInstalled,
+        Checks::CheckTmout,
+        Checks::CheckUpstreamRepository,
+        Checks::Disk::AvailableSpace,
+        Checks::NonRhPackages,
+        Checks::PackageManager::Dnf::ValidateDnfConfig,
+        Checks::Repositories::CheckNonRhRepository,
+        Checks::CheckIpv6Disable,
+        Checks::Disk::AvailableSpacePostgresql13,
+        Checks::CheckOrganizationContentAccessMode,
+        Checks::Repositories::Validate,
+      )
+    end
+
+    it 'composes all steps for Satellite on EL9' do
+      Scenarios::Satellite::PreUpgradeCheck.any_instance.stubs(:el_major_version).returns(9)
+
+      assert_scenario_has_steps(
+        scenario,
+        Checks::ServerPing,
+        Checks::ServicesUp,
+        Checks::SystemRegistration,
+        Checks::CheckHotfixInstalled,
+        Checks::CheckTmout,
+        Checks::CheckUpstreamRepository,
+        Checks::Disk::AvailableSpace,
+        Checks::NonRhPackages,
+        Checks::PackageManager::Dnf::ValidateDnfConfig,
+        Checks::Repositories::CheckNonRhRepository,
+        Checks::CheckIpv6Disable,
+        Checks::Disk::AvailableSpacePostgresql13,
+        Checks::CheckOrganizationContentAccessMode,
+        Checks::Repositories::Validate,
+      )
+    end
+  end
+
+  describe Scenarios::Satellite::PreMigrations do
+    let(:scenario) do
+      Scenarios::Satellite::PreMigrations.new
+    end
+
+    it 'composes all steps for Satellite on EL8' do
+      Scenarios::Satellite::PreMigrations.any_instance.stubs(:el_major_version).returns(8)
+
+      assert_scenario_has_steps(
+        scenario,
+        Procedures::MaintenanceMode::EnableMaintenanceMode,
+        Procedures::Crond::Stop,
+      )
+    end
+
+    it 'composes all steps for Satellite on EL9' do
+      Scenarios::Satellite::PreMigrations.any_instance.stubs(:el_major_version).returns(9)
+
+      assert_scenario_has_steps(
+        scenario,
+        Procedures::MaintenanceMode::EnableMaintenanceMode,
+        Procedures::Crond::Stop,
+      )
+    end
+  end
+
+  describe Scenarios::Satellite::Migrations do
+    let(:scenario) do
+      Scenarios::Satellite::Migrations.new
+    end
+
+    it 'composes all steps for Capsule on EL8' do
+      Scenarios::Satellite::Migrations.any_instance.stubs(:el_major_version).returns(8)
+      assert_scenario_has_step(scenario, Procedures::Packages::EnableModules) do |step|
+        assert_equal(['satellite-capsule:el8'], step.options['module_names'])
+      end
+    end
+
+    it 'composes all steps for Capsule on EL9' do
+      Scenarios::Satellite::Migrations.any_instance.stubs(:el_major_version).returns(9)
+      refute_scenario_has_step(scenario, Procedures::Packages::EnableModules)
+    end
+  end
+
+  describe Scenarios::Satellite::PostMigrations do
+    let(:scenario) do
+      Scenarios::Satellite::PostMigrations.new
+    end
+
+    it 'composes all steps for Satellite on EL8' do
+      Scenarios::Satellite::PostMigrations.any_instance.stubs(:el_major_version).returns(8)
+
+      assert_scenario_has_steps(
+        scenario,
+        Procedures::RefreshFeatures,
+        Procedures::Service::Start,
+        Procedures::Crond::Start,
+        Procedures::MaintenanceMode::DisableMaintenanceMode,
+      )
+    end
+
+    it 'composes all steps for Satellite on EL9' do
+      Scenarios::Satellite::PostMigrations.any_instance.stubs(:el_major_version).returns(9)
+
+      assert_scenario_has_steps(
+        scenario,
+        Procedures::RefreshFeatures,
+        Procedures::Service::Start,
+        Procedures::Crond::Start,
+        Procedures::MaintenanceMode::DisableMaintenanceMode,
+      )
+    end
+  end
+
+  describe Scenarios::Satellite::PostUpgradeChecks do
+    let(:scenario) do
+      Scenarios::Satellite::PostUpgradeChecks.new
+    end
+
+    it 'composes all steps for Satellite on EL8' do
+      Scenarios::Satellite::PostUpgradeChecks.any_instance.stubs(:el_major_version).returns(8)
+
+      assert_scenario_has_steps(
+        scenario,
+        Checks::ServerPing,
+        Checks::ServicesUp,
+        Checks::SystemRegistration,
+        Procedures::Packages::CheckForReboot,
+        Procedures::Pulpcore::ContainerHandleImageMetadata,
+        Procedures::Repositories::IndexKatelloRepositoriesContainerMetatdata,
+      )
+    end
+
+    it 'composes all steps for Satellite on EL9' do
+      Scenarios::Satellite::PostUpgradeChecks.any_instance.stubs(:el_major_version).returns(9)
+
+      assert_scenario_has_steps(
+        scenario,
+        Checks::ServerPing,
+        Checks::ServicesUp,
+        Checks::SystemRegistration,
+        Procedures::Packages::CheckForReboot,
+        Procedures::Pulpcore::ContainerHandleImageMetadata,
+        Procedures::Repositories::IndexKatelloRepositoriesContainerMetatdata,
+      )
+    end
+  end
+end