-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37447 - Add rerun job error #894
Conversation
<Alert | ||
ouiaId="job-wizard-alert-error" | ||
variant="danger" | ||
title={sprintf(errorMessage)} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to have some red empty state like here: https://v4-archive.patternfly.org/v4/components/empty-state/design-guidelines#back-end-failure
With a button to create a job
@kmalyjur ping |
8997bc9
to
f3f1d83
Compare
f3f1d83
to
8997bc9
Compare
175500b
to
8997bc9
Compare
8997bc9
to
5b3663f
Compare
5b3663f
to
7bd0084
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added a meaningful error message when trying to rerun a job with a nonexistent job template.
I think I may have overcomplicated it a bit - it was easy to display a "404" message, but I wanted the more concrete one.
TODO: fix the tests accordingly