Fixes #37447 - Add rerun job error #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaAga
reviewed
Jun 14, 2024
Comment on lines
89
to
93
| <Alert | ||
| ouiaId="job-wizard-alert-error" | ||
| variant="danger" | ||
| title={sprintf(errorMessage)} | ||
| /> |
There was a problem hiding this comment.
I think it would be better to have some red empty state like here: https://v4-archive.patternfly.org/v4/components/empty-state/design-guidelines#back-end-failure
With a button to create a job
|
@kmalyjur ping |
kmalyjur
force-pushed
the
job-wizard-error
branch
2 times, most recently
from
8997bc9
to
f3f1d83
Compare
kmalyjur
force-pushed
the
job-wizard-error
branch
from
f3f1d83
to
8997bc9
Compare
pr-processor
bot
added
Waiting on contributor
and removed
Waiting on contributor
labels
kmalyjur
force-pushed
the
job-wizard-error
branch
from
175500b
to
8997bc9
Compare
kmalyjur
force-pushed
the
job-wizard-error
branch
from
8997bc9
to
5b3663f
Compare
kmalyjur
force-pushed
the
job-wizard-error
branch
from
5b3663f
to
7bd0084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a meaningful error message when trying to rerun a job with a nonexistent job template.
I think I may have overcomplicated it a bit - it was easy to display a "404" message, but I wanted the more concrete one.
TODO: fix the tests accordingly