-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37706 - Add a template that enables download and run of a script #907
Fixes #37706 - Add a template that enables download and run of a script #907
Conversation
required: true | ||
%> | ||
|
||
set -o pipefail && curl -sS <%= input("url") %> | bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure, I'd quote the URL because it may contain &
set -o pipefail && curl -sS <%= input("url") %> | bash | |
set -o pipefail && curl -sS '<%= input("url") %>' | bash |
.gitignore
Outdated
@@ -15,3 +15,4 @@ Gemfile.lock | |||
node_modules/ | |||
package-lock.json | |||
coverage/ | |||
public/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still needed, so split it to a separate PR.
19e5058
to
039d0fb
Compare
Added quotes. |
@ekohl What do you think, would it be OK, or do we want to be more specific and just reuse the snippet from Foreman? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍏 LGTM, works as expected
@ShimShtein, could you please create a RM ticket and attach it to the PR? |
039d0fb
to
ec63276
Compare
The main idea is to execute scripts from the Foreman server, similar to theforeman/foreman#10208.
ec63276
to
2d85464
Compare
@ofedoren Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, all, merging.
The main idea is to execute scripts from the Foreman server, similar to theforeman/foreman#10208.