Only package a static list of files #908
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copies the static list of files from the plugin template. It avoids calling git, which means it works in more environments, but it can cause local files not tracked in git to be included. test_files is avoided because it's deprecated. Primary motivation was packit builds where we temporarily need to include gemfile.d to test against another PR, but don't want that to show up in the final packit RPMs.
|
Looks like we need to remove the files from the spec file too: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the static list of files from the plugin template. It avoids calling git, which means it works in more environments, but it can cause local files not tracked in git to be included. test_files is avoided because it's deprecated.
Primary motivation was packit builds where we temporarily need to include gemfile.d to test against another PR, but don't want that to show up in the final packit RPMs.