Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37594 - "Scroll to bottom/top" javascript links on job details page #909

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

pafernanr
Copy link
Contributor

Description of problem:
After executing an "Ansible command" job the details page shows two links "scroll bottom" and "scroll top" but none of them works.

How reproducible:
Always

Steps to Reproduce:

  1. Execute a "Remote Ansible Command" job
  2. Enter into the Job details page
  3. Click "Scroll to bottom" Link

Actual behavior:
Nothing happens

Expected behavior:
The page scrolls down.

@adamruzicka
Copy link
Contributor

I cloned the original jira into redmine, could you please reword the commit to be in the shape "Fixes #37594 - $description?"

@pafernanr pafernanr changed the title FIX "Scroll to bottom/top" javascript links on job details page Fixes #37594 - "Scroll to bottom/top" javascript links on job details page Jun 25, 2024
Copy link
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamruzicka adamruzicka merged commit 80549c3 into theforeman:master Jul 25, 2024
23 checks passed
@adamruzicka
Copy link
Contributor

Thank you @pafernanr & @MariaAga !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants