Fixes #37847 - Support Rails 7.0 #921
Merged
+4
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
reviewed
Sep 23, 2024
| app.reloader.to_prepare do | ||
| ForemanTasks.dynflow.require! | ||
| ForemanTasks.dynflow.config.queues.add(DYNFLOW_QUEUE, :pool_size => Setting['remote_execution_workers_pool_size']) if Setting.table_exists? rescue(false) | ||
| ForemanTasks.dynflow.config.eager_load_paths << File.join(ForemanRemoteExecution::Engine.root, 'app/lib/actions') |
There was a problem hiding this comment.
What happens if this is not in a reloader.to_prepare block? Doing this each time the application is reloaded would most probably lead to memory bloating? Unless the list of paths to eager load get wiped on reload
There was a problem hiding this comment.
For a long time, Zeitwerk didn't like if during initialization time an autoloadable constant was addressed. In this case Setting, which is a model constant, thus an autoloadable/reloadable constant.
But now it seems redundant to put this into that block...
ofedoren
force-pushed
the
feat-37847-support-rails-7
branch
from
5a54bb4 to
deb8e7f
Compare
ekohl
reviewed
Oct 15, 2024
ofedoren
force-pushed
the
feat-37847-support-rails-7
branch
from
deb8e7f to
94c40be
Compare
ofedoren
force-pushed
the
feat-37847-support-rails-7
branch
from
94c40be to
9f12df2
Compare
|
As of now, this PR can be merged at any time it's ready (dropped the last commit) since it doesn't depend on Foreman's PR. |
ofedoren
force-pushed
the
feat-37847-support-rails-7
branch
from
9f12df2 to
7ce103c
Compare
|
Thank you @ofedoren ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.